Well, Federal Pacific were among the most notoriously bad panels ever made. Not only did the back planes make poor contact but the breakers often failed to trip on overload.
Square D, Siemens, Eaton CH are all really good. My preference is for in-panel surge protectors as opposed to bolt on units. I’d suggest go with whichever your electrician recommends that allows a surge protector to plug directly onto the back plane instead of being wired in. This minimizes inductance and puts the surge protector closest to the incoming power lines.